-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename log.path field to log.file.path to be ECS complicant #27761
Rename log.path field to log.file.path to be ECS complicant #27761
Conversation
Pinging @elastic/agent (Team:Agent) |
It seems this is a breaking change. Will this potentially have some side effects? |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ℹ️ The Logs UI already uses |
It is a breaking change compared to the previous version. However, everyone expects filestream input to be ECS compliant, so I consider the old behaviour an obstacle for adaptation. It makes moving from log input to filestream input harder if we do not merge this in 7.x. EDIT: It was reported here on Discuss: https://discuss.elastic.co/t/filebeat-input-types-log-and-filestream-metadata-for-file-path-name-differ/281713 |
++ on following ECS. We should likely file it then as bug and breaking change. Any user that has build dashboards or tooling of the existing fields will have issues afterwards. |
This pull request is now in conflicts. Could you fix it? 🙏
|
fcb2c05
to
0beaafb
Compare
I have opened an issue as well and added one more entry to the changelog. |
This pull request is now in conflicts. Could you fix it? 🙏
|
0beaafb
to
f1c2aeb
Compare
…cant (elastic#27761) (cherry picked from commit 66eb101)
What does this PR do?
The PR renames
log.path
tolog.file.path
in filestream input events.Why is it important?
The old
log.path
is not ECS compliant and inconsistent with the old log input.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Closes #27776