-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LineReader: Reuse temporary buffer to reduce per-line allocation #27782
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // Licensed to Elasticsearch B.V. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. Elasticsearch B.V. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package readfile | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/hex" | ||
| "fmt" | ||
| "io" | ||
| "io/ioutil" | ||
| "math/rand" | ||
| "testing" | ||
|
|
||
| "golang.org/x/text/encoding" | ||
| ) | ||
|
|
||
| func BenchmarkEncoderReader(b *testing.B) { | ||
| const ( | ||
| bufferSize = 1024 | ||
| lineMaxLimit = 1000000 // never hit by the input data | ||
| ) | ||
|
|
||
| runBench := func(name string, lineMaxLimit int, lines []byte) { | ||
| b.Run(name, func(b *testing.B) { | ||
| b.ReportAllocs() | ||
| for bN := 0; bN < b.N; bN++ { | ||
| reader, err := NewEncodeReader(ioutil.NopCloser(bytes.NewReader(lines)), Config{encoding.Nop, bufferSize, LineFeed, lineMaxLimit}) | ||
| if err != nil { | ||
| b.Fatal("failed to initialize reader:", err) | ||
| } | ||
| // Read decodec lines and test | ||
| size := 0 | ||
| for i := 0; ; i++ { | ||
| msg, err := reader.Next() | ||
| if err != nil { | ||
| if err == io.EOF { | ||
| b.ReportMetric(float64(i), "processed_lines") | ||
| break | ||
| } else { | ||
| b.Fatal("unexpected error:", err) | ||
| } | ||
| } | ||
| size += msg.Bytes | ||
| } | ||
| b.ReportMetric(float64(size), "processed_bytes") | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| runBench("buffer-sized lines", lineMaxLimit, createBenchmarkLines(100, 1020)) | ||
| runBench("short lines", lineMaxLimit, createBenchmarkLines(100, 10)) | ||
| runBench("long lines", lineMaxLimit, createBenchmarkLines(100, 10_000)) | ||
| // short lineMaxLimit to exercise skipUntilNewLine | ||
| runBench("skip lines", 1024, createBenchmarkLines(100, 10_000)) | ||
| } | ||
|
|
||
| func createBenchmarkLines(numLines int, lineLength int) []byte { | ||
| buf := bytes.NewBuffer(nil) | ||
| for i := 0; i < numLines; i++ { | ||
| line := make([]byte, hex.DecodedLen(lineLength)) | ||
| if _, err := rand.Read(line); err != nil { | ||
| panic(fmt.Sprintf("failed to generate random input: %v", err)) | ||
| } | ||
| buf.WriteString(hex.EncodeToString(line)) | ||
| buf.WriteRune('\n') | ||
| } | ||
| return buf.Bytes() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you all have preferences on where/how to include benchmarks. Happy to move/remove this as desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine where you put it.