Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. #28434

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Implements host_users, host_groups, host_processes tables as a part of our osquery_extension.
The expectation is that the /etc/passwd, /etc/group, /proc
are available in the container under /hostfs as: /hostfs/etc/passwd, /hostfs/etc/group, /hostfs/proc.
The ELASTIC_OSQUERY_HOSTFS environment variable allows to change the default.
The processes.on_disk column is always set to -1.

Opening as a draft/POC, will do another pass.

Why is it important?

Addresses https://github.com/elastic/security-team/issues/1812

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

Related issues

Screenshots

Screen Shot 2021-10-14 at 7 00 44 AM

Screen Shot 2021-10-14 at 7 01 03 AM

Screen Shot 2021-10-14 at 7 01 46 AM

… as a part of our osquery_extension.

* The expectation is that the /etc/passwd,  /etc/group,  /proc
are avaiable in the container under /hostfs as: /hostfs/etc/passwd, /hostfs/etc/group, /hostfs/proc.
The ELASTIC_OSQUERY_HOSTFS environment variable allows to change the default.
* The on_disk column is always set to -1
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

This pull request does not have a backport label. Could you fix it @aleksmaus? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 14, 2021
@aleksmaus aleksmaus added the backport-v7.16.0 Automated backport with mergify label Oct 14, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 14, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 88 min 45 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

// Check that it is convertable to int type
switch col.Type {
case ColumnTypeUint:
// For unsigned values (Apple) the number is parsed as signed int32 then converted to unsigned.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great example

@aleksmaus
Copy link
Member Author

Screen Shot 2021-10-18 at 11 13 25 AM

Screen Shot 2021-10-18 at 11 29 22 AM

Screen Shot 2021-10-18 at 11 25 24 AM

@aleksmaus aleksmaus marked this pull request as ready for review October 19, 2021 17:08
@aleksmaus aleksmaus merged commit ec8e051 into elastic:master Oct 20, 2021
mergify bot pushed a commit that referenced this pull request Oct 20, 2021
… as a part of our osquery_extension. (#28434)

* Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension.

* The expectation is that the /etc/passwd,  /etc/group,  /proc
are avaiable in the container under /hostfs as: /hostfs/etc/passwd, /hostfs/etc/group, /hostfs/proc.
The ELASTIC_OSQUERY_HOSTFS environment variable allows to change the default.
* The on_disk column is always set to -1

* Remove erroneous comment line

(cherry picked from commit ec8e051)
aleksmaus added a commit that referenced this pull request Oct 20, 2021
… as a part of our osquery_extension. (#28434) (#28553)

* Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension.

* The expectation is that the /etc/passwd,  /etc/group,  /proc
are avaiable in the container under /hostfs as: /hostfs/etc/passwd, /hostfs/etc/group, /hostfs/proc.
The ELASTIC_OSQUERY_HOSTFS environment variable allows to change the default.
* The on_disk column is always set to -1

* Remove erroneous comment line

(cherry picked from commit ec8e051)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Oct 26, 2021
…urnalbeat-ci

* upstream/master: (49 commits)
  [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589)
  fix: use declarative style for complete variant of the elastic-agent (elastic#28526)
  x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609)
  docs: Update `api_key` example on elasticsearch output (elastic#28606)
  chore: add build scripts to CODEOWNERS (elastic#28615)
  Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622)
  Add note about changes to regexp package in Golang (elastic#28616)
  CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612)
  Osquerybeat: Fix extenstion unable to start on windows (elastic#28598)
  Osquerybeat: Return the query result count with the action response (elastic#28576)
  Agent: Allow custom response properties in the action response (elastic#28575)
  [Heartbeat] Only setuid in elastic-agent image (elastic#28577)
  Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530)
  CI: refactor the run e2e build (elastic#28502)
  Use fsnotify with long windows name-safe changes (elastic#28517)
  Remove unneeded mergify config
  backport: Add 7.16 branch (elastic#28560)
  Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533)
  Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434)
  [Heartbeat] Make run_once syntax a boolean (elastic#28548)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
… as a part of our osquery_extension. (elastic#28434)

* Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension.

* The expectation is that the /etc/passwd,  /etc/group,  /proc
are avaiable in the container under /hostfs as: /hostfs/etc/passwd, /hostfs/etc/group, /hostfs/proc.
The ELASTIC_OSQUERY_HOSTFS environment variable allows to change the default.
* The on_disk column is always set to -1

* Remove erroneous comment line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants