Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Set log level to warn for zip download errors #28440

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[Heartbeat] Set log level to warn for zip download errors #28440

merged 2 commits into from
Oct 14, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Oct 14, 2021 •
edited
Loading

This was set to Info for no good reason, causing it to not show up in agent logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc
[Heartbeat] Set log level to warn for zip download errors
dd305b2 
This was set to Info for no good reason, causing it to not show up in
agent logs.
@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.16.0 backport-v7.16.0 Automated backport with mergify labels Oct 14, 2021
@andrewvc andrewvc self-assigned this Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2021
justinkambic
justinkambic approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T12:44:53.907+0000

  • Duration: 61 min 23 sec

  • Commit: d4bd68b

Test stats 🧪

Test Results
Failed 0
Passed 93
Skipped 0
Total 93

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewvc andrewvc merged commit ce0eda1 into elastic:master Oct 14, 2021
@andrewvc andrewvc deleted the log-zip-fails branch October 14, 2021 13:57
mergify bot pushed a commit that referenced this pull request Oct 14, 2021
@andrewvc
[Heartbeat] Set log level to warn for zip download errors (#28440)
7355bd5 
* [Heartbeat] Set log level to warn for zip download errors

This was set to Info for no good reason, causing it to not show up in
agent logs.

* changelog

(cherry picked from commit ce0eda1)
@mergify mergify bot mentioned this pull request Oct 14, 2021
Merged
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@andrewvc
[Heartbeat] Set log level to warn for zip download errors (elastic#28440
8980ee1 
)

* [Heartbeat] Set log level to warn for zip download errors

This was set to Info for no good reason, causing it to not show up in
agent logs.

* changelog
andrewvc added a commit that referenced this pull request Nov 1, 2021
@mergify @andrewvc
[Heartbeat] Set log level to warn for zip download errors (#28440) (#…
fa90c49 
…28446)

* [Heartbeat] Set log level to warn for zip download errors

This was set to Info for no good reason, causing it to not show up in
agent logs.

* changelog

(cherry picked from commit ce0eda1)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v7.16.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @justinkambic