Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy_url support to threatintel module's malwarebazaar fileset #28533

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

adriansr
Copy link
Contributor

What does this PR do?

This PR adds proxy support to threatintel module's malwarebazaar fileset.

Also updates the docs to reflect all the existing proxy_url options in other filesets.

Why is it important?

With this change, all the Threat Intel sources support the proxy_url configuration option.

The only exception is the anomali_threatstream fileset which acts as an HTTP server so it has no use for a proxy option. For this fileset, proxy is configured in the SDK provided by Anomali.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@adriansr adriansr added enhancement Filebeat Filebeat backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Oct 19, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2021
@adriansr
Copy link
Contributor Author

Windows 2008 tests failed due to

curl: (28) Failed to connect to github.com port 443: Timed out

Ignoring this flakiness

@adriansr adriansr merged commit 15abbe6 into elastic:master Oct 20, 2021
mergify bot pushed a commit that referenced this pull request Oct 20, 2021
…28533)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)
mergify bot pushed a commit that referenced this pull request Oct 20, 2021
…28533)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)
adriansr added a commit to adriansr/beats that referenced this pull request Oct 20, 2021
…lastic#28533)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)
adriansr added a commit that referenced this pull request Oct 20, 2021
…28533) (#28565)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
adriansr added a commit that referenced this pull request Oct 20, 2021
…28533) (#28567)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)
v1v added a commit to v1v/beats that referenced this pull request Oct 26, 2021
…urnalbeat-ci

* upstream/master: (49 commits)
  [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589)
  fix: use declarative style for complete variant of the elastic-agent (elastic#28526)
  x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609)
  docs: Update `api_key` example on elasticsearch output (elastic#28606)
  chore: add build scripts to CODEOWNERS (elastic#28615)
  Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622)
  Add note about changes to regexp package in Golang (elastic#28616)
  CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612)
  Osquerybeat: Fix extenstion unable to start on windows (elastic#28598)
  Osquerybeat: Return the query result count with the action response (elastic#28576)
  Agent: Allow custom response properties in the action response (elastic#28575)
  [Heartbeat] Only setuid in elastic-agent image (elastic#28577)
  Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530)
  CI: refactor the run e2e build (elastic#28502)
  Use fsnotify with long windows name-safe changes (elastic#28517)
  Remove unneeded mergify config
  backport: Add 7.16 branch (elastic#28560)
  Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533)
  Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434)
  [Heartbeat] Make run_once syntax a boolean (elastic#28548)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…lastic#28533)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#28533) (elastic#28565)

Adds proxy_url config option to malwarebazaar

Documents all proxy_url options for threat_intel

(cherry picked from commit 15abbe6)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify enhancement Filebeat Filebeat review v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants