[filebeat][s3] Add custom parsing script for S3 notifications #28946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
Team:Security-External Integrations
backport-v8.0.0
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
marc-gr
force-pushed
the
awss3-support-sns
branch
from
afacd90
to
49988f9
Compare
It can be used as a regular JS map since its only purpose is to be read.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Do we have a use case where the notification received via SQS isn't JSON? I'm just wondering if we need full JavaScript support or if greater flexibility in JSON parsing would be sufficient. |
efd6
reviewed
Nov 14, 2021
andrewkroh
reviewed
Nov 15, 2021
andrewkroh
approved these changes
Nov 18, 2021
|
Pinging @elastic/integrations (Team:Integrations) |
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Add custom parsing script for S3 notifications * Remove unnecessary custom jsmapstr type. It can be used as a regular JS map since its only purpose is to be read. * add docs and changelog entry * Remove commented code * Document script options restriction * Better error if Records are missing in notification * Fix test * Pass notification as string and add xml parsing options for the scripts (cherry picked from commit df3fcec)
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Add custom parsing script for S3 notifications * Remove unnecessary custom jsmapstr type. It can be used as a regular JS map since its only purpose is to be read. * add docs and changelog entry * Remove commented code * Document script options restriction * Better error if Records are missing in notification * Fix test * Pass notification as string and add xml parsing options for the scripts (cherry picked from commit df3fcec)
marc-gr
added a commit
that referenced
this pull request
Nov 18, 2021
#29027) * Add custom parsing script for S3 notifications * Remove unnecessary custom jsmapstr type. It can be used as a regular JS map since its only purpose is to be read. * add docs and changelog entry * Remove commented code * Document script options restriction * Better error if Records are missing in notification * Fix test * Pass notification as string and add xml parsing options for the scripts (cherry picked from commit df3fcec) Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
marc-gr
added a commit
that referenced
this pull request
Nov 18, 2021
…S3 notifications (#29026) * [filebeat][s3] Add custom parsing script for S3 notifications (#28946) * Add custom parsing script for S3 notifications * Remove unnecessary custom jsmapstr type. It can be used as a regular JS map since its only purpose is to be read. * add docs and changelog entry * Remove commented code * Document script options restriction * Better error if Records are missing in notification * Fix test * Pass notification as string and add xml parsing options for the scripts (cherry picked from commit df3fcec) * Remove Provider field not present in branch Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
rstatsinger
requested review from
rstatsinger
and removed request for
rstatsinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to define a custom parsing script to deal with non-standard S3 notifications received through SQS.
Improves error handling for malformed S3 notifications.
Why is it important?
In some scenarios the received SQS notification might be non-standard. This change lets the user define a custom parsing script to deal with them.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Closes #28828