Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] keep track of bytes read when max_bytes exceeded #31824

Merged

Conversation

liuwenping
Copy link
Contributor

What does this PR do?

Newlines also need to be recorded in the skipped characters

Why is it important?

The skipped newline character is not recorded in the registry when the max_bytes(maximum limit of a single line) is exceeded. as the number of long lines increases, it will cause repeated reading problems

The relevant PR is #28352

@liuwenping liuwenping requested a review from a team as a code owner June 4, 2022 09:20
@liuwenping liuwenping requested review from rdner and cmacknz and removed request for a team June 4, 2022 09:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 4, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-07T10:14:20.146+0000

  • Duration: 76 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 22260
Skipped 1935
Total 24195

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz requested review from kvch and leehinman June 6, 2022 17:52
@cmacknz
Copy link
Member

cmacknz commented Jun 6, 2022

@leehinman this looks like a follow up to a similar change you made elsewhere in this file, can you review it? #28352

@liuwenping is there a test case we can add for this?

@cmacknz
Copy link
Member

cmacknz commented Jun 6, 2022

/test

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 6, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 6, 2022
@liuwenping
Copy link
Contributor Author

@leehinman this looks like a follow up to a similar change you made elsewhere in this file, can you review it? #28352

@liuwenping is there a test case we can add for this?

Updated

@rdner
Copy link
Member

rdner commented Jun 7, 2022

/test

@andrewkroh
Copy link
Member

After this change one of the tests in the reader package has started failing. #31863.

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Keep track of bytes read when max_bytes exceeded
Add test code for exceeding max bytes in filebeat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants