Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve couchbase module #3545

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Feb 7, 2017

  • Fix typo spacial to spatial. Change fieldnames couchbase.node.couch..actual_disk_size. to couchbase.node.couch..disk_size. for consistency.
  • Add system tests to verify docs
  • Update data.json

* Fix typo spacial to spatial. Change fieldnames couchbase.node.couch.*.actual_disk_size.* to couchbase.node.couch.*.disk_size.* for consistency.
* Add system tests to verify docs
* Update data.json
@@ -625,14 +625,14 @@
},
"views": {
"properties": {
"actual_disk_size": {
"data_size": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't disk_size instead of data_size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is confusing here. disk_size is acutally on like 635 and data_size was moved up here (alphabetical sorting).

"properties": {
"bytes": {
"type": "long"
}
}
},
"data_size": {
"disk_size": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this by intention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@monicasarbu monicasarbu merged commit a8bd416 into elastic:master Feb 7, 2017
@ruflin ruflin deleted the spacial-to-spatial branch February 7, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants