Improvements to beatname.sh #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/beatname-sh
branch
from
5111f0e
to
cfe96e6
Compare
|
I did a quick manual test on Centos 7. |
exekias
suggested changes
Aug 29, 2017
| @@ -1,9 +1,9 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env | |||
There was a problem hiding this comment.
I think bash is missing here
There was a problem hiding this comment.
Probably should have copied the file instead of typing it twice.
Use `exec` with the command to start the beat so that it replaces the shell process leaving only the beat process. This is nicer because you don't have the "beatname.sh" process showing up in `ps` output. Change the hashbang to `#!/usr/bin/env bash` instead of `#!/bin/bash`. This is generally more portable.
andrewkroh
force-pushed
the
feature/beatname-sh
branch
from
cfe96e6
to
2134d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
execwith the command to start the beat so that it replaces the shell process leaving only the beat process. This is nicer because you don't have the "beatname.sh" process showing up inpsoutput.Change the hashbang to
#!/usr/bin/env bashinstead of#!/bin/bash. This is generally more portable.