Check modules and prospectors settings when reload is off #5053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
force-pushed
the
check-modules-reload
branch
from
594c148
to
7388f56
Compare
This change ensures that we check configs when loading them through `filebeat.config.modules`, `filebeat.config.prospectors` or `metricbeat.config.modules`. It will error and exit if settings are wrong and **reload is disabled**
exekias
force-pushed
the
check-modules-reload
branch
from
7388f56
to
222ee2c
Compare
exekias
added
bug
Filebeat
|
Please note that it conflicts with my PR #5026, so one of us will have to rebase their branch after merging. :) |
kvch
approved these changes
Aug 29, 2017
kvch
reviewed
Aug 29, 2017
| done: make(chan struct{}), | ||
| } | ||
| } | ||
|
|
||
| // Check configs are valid (only if reload is disabled) | ||
| func (rl *Reloader) Check(runnerFactory RunnerFactory) error { |
There was a problem hiding this comment.
It is quite similar to the existing config reload code in Run function. I would extract anything that could be extracted into smaller functions. So those could be reused it in both Check and Run. Thus, code duplication could be eliminated.
There was a problem hiding this comment.
I'll do some refactoring, thanks!
|
I have one concerns regarding the code. I have already accepted your PR, so decide if you would address it or not. |
exekias
added
v6.0.0-rc1
and removed
in progress
|
This should be ready for a second look |
|
After it turns green, I would merge it. |
exekias
removed
the
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Sep 6, 2017
* Check modules and prospectors settings when reload is off This change ensures that we check configs when loading them through `filebeat.config.modules`, `filebeat.config.prospectors` or `metricbeat.config.modules`. It will error and exit if settings are wrong and **reload is disabled** * Extract common operations from check and start (cherry picked from commit 4c17368)
tsg
pushed a commit
that referenced
this pull request
Sep 7, 2017
) * Check modules and prospectors settings when reload is off This change ensures that we check configs when loading them through `filebeat.config.modules`, `filebeat.config.prospectors` or `metricbeat.config.modules`. It will error and exit if settings are wrong and **reload is disabled** * Extract common operations from check and start (cherry picked from commit 4c17368)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…) (elastic#5107) * Check modules and prospectors settings when reload is off This change ensures that we check configs when loading them through `filebeat.config.modules`, `filebeat.config.prospectors` or `metricbeat.config.modules`. It will error and exit if settings are wrong and **reload is disabled** * Extract common operations from check and start (cherry picked from commit ac3d0dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we check configs when loading them through
filebeat.config.modules,filebeat.config.prospectorsormetricbeat.config.modules.It will error and exit if settings are wrong and reload is disabled
Part of #4810