Remove error log from runnerfactory as error is returned by API #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vjsamuel
force-pushed
the
remove_runnerfactory_error
branch
from
8c96ee2
to
e3e3770
Compare
|
ok to test |
ruflin
reviewed
Sep 4, 2017
| @@ -28,7 +27,6 @@ func NewRunnerFactory(outlet channel.Factory, registrar *registrar.Registrar, be | |||
| func (r *RunnerFactory) Create(c *common.Config) (cfgfile.Runner, error) { | |||
| p, err := New(c, r.outlet, r.beatDone, r.registrar.GetStates()) | |||
| if err != nil { | |||
| logp.Err("Error creating prospector: %s", err) | |||
There was a problem hiding this comment.
LGTM. The only problem with the error logged by the runner factory is probably that it's more generic and does not talk about the prospector itself?
There was a problem hiding this comment.
One option would be to use errors.Wrap in prospector.Newhttps://github.com/vjsamuel/beats/blob/e3e3770af3dd7d3f4563955274aff976f415d9cd/filebeat/prospector/prospector.go#L34
There was a problem hiding this comment.
Merged it as is as I kind of like producing errors in as few places and just pass them on. We can still improve it in case it becomes an issue.
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same error that is being logged is also being returned by the API. it should be the caller's choice to decide if its a debug/info/error level log.