MB mongodb module: connect on fetch, not on init #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
Metricbeat
Moving the Dial call to the Fetch, so that in case Mongodb is not (yet) available, Metricbeat doesn't exit with an error, but just reports the service being down. This is consistent with the way most of the other modules are working. Fixes elastic#5090
tsg
force-pushed
the
mongodb_connect_on_fetch
branch
from
9a85715
to
1dff6ab
Compare
tsg
added a commit
to tsg/beats
that referenced
this pull request
Sep 7, 2017
MB mongodb module: connect on fetch, not on init Moving the Dial call to the Fetch, so that in case Mongodb is not (yet) available, Metricbeat doesn't exit with an error, but just reports the service being down. This is consistent with the way most of the other modules are working. Fixes elastic#5090 (cherry picked from commit 9c9eaab)
exekias
pushed a commit
that referenced
this pull request
Sep 8, 2017
… init (#5128) MB mongodb module: connect on fetch, not on init Moving the Dial call to the Fetch, so that in case Mongodb is not (yet) available, Metricbeat doesn't exit with an error, but just reports the service being down. This is consistent with the way most of the other modules are working. Fixes #5090 (cherry picked from commit 9c9eaab)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… not on init (elastic#5128) MB mongodb module: connect on fetch, not on init Moving the Dial call to the Fetch, so that in case Mongodb is not (yet) available, Metricbeat doesn't exit with an error, but just reports the service being down. This is consistent with the way most of the other modules are working. Fixes elastic#5090 (cherry picked from commit 01fc151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the Dial call to the Fetch, so that in case Mongodb is not (yet)
available, Metricbeat doesn't exit with an error, but just reports the
service being down. This is consistent with the way most of the other
modules are working.
Fixes #5090