Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricbeat: add more node metrics in elasticseach module #5320

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

wangdisdu
Copy link
Contributor

metricbeat: add more node metrics in elastics each module

node:

  • jvm.memory.heap.init
  • jvm.memory.heap.max
  • jvm.memory.nonheap.init
  • jvm.memory.nonheap.max
  • process.mlockall

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@ruflin
Copy link
Member

ruflin commented Oct 6, 2017

@wangdisdu Could you share some more details on how you use these metrics in your environment?

@wangdisdu
Copy link
Contributor Author

wangdisdu commented Oct 7, 2017

@ruflin Well, i build many charts with echart in use of "node stats" metrics. With the charts showing jvm memory used by heap and nonheap, i am able to add two base lines: init line, and max line, so that for example, i can figure out unhealthy state when the used line is approaching the max line.

For the process.mlockall, it is very important for me. if it is false, means system environment configuration is incorrectly set, i need to fix it and restart elasticsearch.

@ruflin
Copy link
Member

ruflin commented Oct 10, 2017

@wangdisdu Thanks for sharing the details. How does the data from beats end up in echarts? Is that on top of elasticsearch?

We are looking into which values we should add to elasticsearch module without adding too many values. We will keep you posted.

"heap_init": s.Object{
"bytes": c.Int("heap_init_in_bytes"),
"heap": s.Object{
"init": s.Object{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself: this is a breaking change.

@ruflin
Copy link
Member

ruflin commented Oct 10, 2017

@wangdisdu I think we should move forward with this PR. Could you add a line to the CHANGELOG under breaking changes as the heap.init which was heap_init is a breaking change?

@wangdisdu wangdisdu force-pushed the metricbeat-es-node branch 2 times, most recently from 52ab248 to 6e9c4f8 Compare October 11, 2017 03:13
@wangdisdu
Copy link
Contributor Author

@ruflin Thanks for your reviewed. I has added the breaking change log into CHANGELOG: Rename heap_init field to heap.init.

By the way, the echarts is just a javascript libaray. The echarts can be used to build beautiful chart with the metric data that beats collect and store into elasticsearch.

@ruflin
Copy link
Member

ruflin commented Oct 11, 2017

jenkins, test it

@ruflin ruflin merged commit 5261079 into elastic:master Oct 12, 2017
@ruflin
Copy link
Member

ruflin commented Oct 12, 2017

@wangdisdu Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants