Refactor add_kubernetes_metadata to support autodiscovery #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vjsamuel
force-pushed
the
refactor_add_kubernetes
branch
from
1d4e375
to
ac71479
Compare
vjsamuel
force-pushed
the
refactor_add_kubernetes
branch
from
ac71479
to
c902d6d
Compare
|
jenkins, test it please |
exekias
approved these changes
Oct 27, 2017
|
LGTM, as a note, we will also need to move podwatcher to some common place, as I did for the docker one here: #5245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodiscovery when it is available must be able to use indexers. Indexers are currently exclusive to
add_kubernetes_metadata. This also prevents collectbeat from using them. This PR moves code around to reduce file sizes and exposes some of the needed functionality inadd_kubernetes_metadata.