Foundation for Logstash Metricbeat module #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
houndci-bot
reviewed
Nov 8, 2017
| return port | ||
| } | ||
|
|
||
| func GetConfig(metricset string) map[string]interface{} { |
There was a problem hiding this comment.
exported function GetConfig should have comment or be unexported
| return host | ||
| } | ||
|
|
||
| func GetEnvPort() string { |
There was a problem hiding this comment.
exported function GetEnvPort should have comment or be unexported
|
|
||
| import "os" | ||
|
|
||
| func GetEnvHost() string { |
There was a problem hiding this comment.
exported function GetEnvHost should have comment or be unexported
houndci-bot
reviewed
Nov 8, 2017
| return port | ||
| } | ||
|
|
||
| func GetConfig(metricset string) map[string]interface{} { |
There was a problem hiding this comment.
exported function GetConfig should have comment or be unexported
| return host | ||
| } | ||
|
|
||
| func GetEnvPort() string { |
There was a problem hiding this comment.
exported function GetEnvPort should have comment or be unexported
|
|
||
| import "os" | ||
|
|
||
| func GetEnvHost() string { |
There was a problem hiding this comment.
exported function GetEnvHost should have comment or be unexported
ruflin
force-pushed
the
logstash-module
branch
from
48ebdc7
to
02f8a76
Compare
ruflin
added
review
and removed
in progress
ruflin
force-pushed
the
logstash-module
branch
from
0811a7c
to
5bfbd34
Compare
This are the base documents for the Logstash Metricbeat module. This allows to easily add more metricsets and metricsets in the future. So far it is marked as experimental. Having this module should also help to sync the document structure with the Logstash filebeat module (@ph).
ruflin
force-pushed
the
logstash-module
branch
from
6a833cb
to
42b7599
Compare
4 tasks
|
Thanks, added on more not the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are the base documents for the Logstash Metricbeat module. This allows to easily add more metricsets and metricsets in the future. So far it is marked as experimental.
Having this module should also help to sync the document structure with the Logstash filebeat module (@ph).