Metricbeat - Vsphere module - Fix Error collecting network_names #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
andrewkroh
reviewed
Dec 27, 2017
| @@ -215,8 +215,20 @@ func getNetworkNames(c *vim25.Client, ref types.ManagedObjectReference) ([]strin | |||
| return nil, errors.Wrap(err, "no networks found") | |||
| } | |||
|
|
|||
| networksRefs := []types.ManagedObjectReference{} | |||
There was a problem hiding this comment.
Use var networkRefs types.ManagedObjectReferenc instead. https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices
There was a problem hiding this comment.
Changed, thanks for the link!
|
|
||
| // If only "Distributed port group" was found, for example. | ||
| if len(networksRefs) == 0 { | ||
| return nil, errors.Wrap(err, "no networks found") |
There was a problem hiding this comment.
I think you want errors.New instead of errors.Wrap because err == nil here. Same thing with the earlier errors.Wrap usage.
ruflin
changed the title
|
Could you add a changelog? I adjusted the title of the PR a bit. |
|
jenkins, test it |
|
@amandahla Could you rebase this PR on master? |
|
@ruflin Sure! Done :) |
|
@amandahla Just wanted to merge this but there is now a conflict in the CHANGELOG :-( Sorry. Can you rebase again? |
|
No problem! :) |
|
jenkins, test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages occurs because virtualmachine have "distributed port group" instead of "network". It was already fixed in "host" and now it was made the same in "virtualmachine".
Closes #5961