Fix conditions checking on autodiscover Docker labels #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
bug
in progress
exekias
changed the title
exekias
changed the title
exekias
force-pushed
the
fix-autodiscover-docker-labels
branch
from
76c2d0f
to
33ca0d6
Compare
Type was wrong (map[string]string instead of MapStr) so labels were not being processed.
exekias
force-pushed
the
fix-autodiscover-docker-labels
branch
from
33ca0d6
to
f1b38e6
Compare
exekias
added
review
v6.3.0
v6.2.2
and removed
in progress
exekias
added a commit
to exekias/beats
that referenced
this pull request
Feb 20, 2018
Type was wrong (map[string]string instead of MapStr) so labels were not being processed. (cherry picked from commit db49ae8)
exekias
removed
the
needs_backport
|
How can this be used in autodiscovery? This doesn't seem to work: I am using 6.2.3. |
|
The condition seems to be wrong? |
|
@m4ce Could you open a topic on discuss with this? https://discuss.elastic.co/c/beats/filebeat Please provide there also the list of labels you have in docker. |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ver Docker labels (elastic#6420) * Fix autodiscover Docker labels processing (elastic#6412) Type was wrong (map[string]string instead of MapStr) so labels were not being processed. (cherry picked from commit 62aa907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type was wrong (map[string]string instead of MapStr) so autodiscover conditions on Docker labels were not being processed.