Use safe put for k8s metadata #6490
Conversation
|
jenkins, retest it please |
exekias
force-pushed
the
safemapstr-kubernetes
branch
from
5b0c941
to
f077e20
Compare
exekias
force-pushed
the
safemapstr-kubernetes
branch
from
f077e20
to
2769964
Compare
| @@ -114,7 +115,7 @@ func generateMapStrFromEvent(eve *kubernetes.Event) common.MapStr { | |||
| if len(eve.Metadata.Annotations) != 0 { | |||
| annotations := make(common.MapStr, len(eve.Metadata.Annotations)) | |||
| for k, v := range eve.Metadata.Annotations { | |||
| annotations[common.DeDot(k)] = v | |||
| safemapstr.Put(annotations, k, v) | |||
There was a problem hiding this comment.
I wonder if we should document this under breaking changes? As in case someone filtered for the annotations this queries now stop working. Will still merge the PR but we can discuss this as a follow up.
There was a problem hiding this comment.
Note: I agree this is a bug fix in general.
There was a problem hiding this comment.
Yep, I wonder how we should communicate this, so far without this change the only way to get some field that is renamed by this was using drop_field processor to ensure there are no mapping issues.
There was a problem hiding this comment.
As we link to the PR in the changelog could you add more details to the PR message? So people ending up on this PR get some background info?
This makes use of #6434 as an alternative to avoid mapping issues while keeping dots in metadata.
Before this change, label sets breaking nesting would result in mapping errors, for example this one:
Now we do preemptive renaming to avoid errors (.value is appended to
co.elastic.task):