Set default metricset in windows module to service

[jsoriano]

See #6668

[ruflin]

Reference file should definitiveyl contain both options. Probably a config.reference.yml has to be added.

[ruflin]

Can you update the docs and quickly mention in the PR on why perfmon is the default metricset. So in case we come back later to this PR again, we know.

[jsoriano]

Added reference config and updated doc.

Regarding why chosing perfmon as default option I don't have a strong opinion on that, I only though that maybe by default the user may not want to monitor all services.
What do you think? Should we enable both metricsets by default?

[andrewkroh]

perfmon requires configuration so maybe it shouldn't be a "default". You must configure perfmon.counters in order for it to be useful so I think this example needs improvement.

The service metricset does not require any configuration so it might be a good default. But TBH the default period of 10s is a excessive. I'd probably increase it 60s at a minimum or drop events for healthy services.

[ruflin]

+1 on the proposal. As we have now also a config.reference.yml we can set the period to 60s (non default) in the config.yml. Also we can add a processor to drop the healthy events with a processor in the config.yml.

[jsoriano]

Agree with the proposals, thanks @andrewkroh

Would it be ok to set a different default for the period in the initialization of this module?

[ruflin]

It would be possible but as the default period is possible, I would not do that and use the config.yml for it. This keeps the code and defaults simple, but still allows us to overwrite them.

[jsoriano]

Oh, period is module-wide 🤔 it shouldn't be set from the metricset.

[ruflin]

You can define a module multiple times in the config if you want to have different periods for different metricsets.

[jsoriano]

Changed default metricset to service, reverted changes in periods in reference config, and added commented-out example for perfmon.

[ruflin]

Now it becomes interesting. In the reference config we should use defaults and only in config.ymloverwrite the defaults. At least that is what we did so far.

[jsoriano]

This is how periods were in the reference config before this PR :)

I think that supporting different default periods can make a lot of sense (this module is a good example), but this gives for a bigger discussion out of the scope of this PR, wdyt?

[ruflin]

That we had different periods in the reference config was more an accident as the values were taken from the short config. Now that we have a reference file we could use the default one.

There are a lot of interesting discussion popping up with our changes here. We can take these offline. Will merge as is for now.