Ensure the dashboard zip is sane #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check that all files from the dashboard zip file are pointing to the right target, and don't override other configs.
urso
reviewed
Apr 23, 2018
libbeat/dashboards/importer.go
Outdated
| return err | ||
| } | ||
| if strings.HasPrefix(filepath.ToSlash(relPath), "../") { | ||
| return fmt.Errorf("Zip file contains files outside of directory target: %s", relPath) |
urso
approved these changes
Apr 23, 2018
ruflin
approved these changes
Apr 23, 2018
|
If I may I'd recommend using |
tsg
added a commit
to tsg/beats
that referenced
this pull request
May 2, 2018
This uses the same approach and code as the Kibana dashboards loader. Fixes elastic#6921.
tsg
added a commit
to tsg/beats
that referenced
this pull request
May 2, 2018
* Ensure the dashboard zip is sane This adds a check that all files from the dashboard zip file are pointing to the right target, and don't override other configs. * changelog * addressed comment (cherry picked from commit a34c9eb)
tsg
added
v6.3.0
and removed
needs_backport
tsg
added a commit
to tsg/beats
that referenced
this pull request
May 2, 2018
* Ensure the dashboard zip is sane This adds a check that all files from the dashboard zip file are pointing to the right target, and don't override other configs. * changelog * addressed comment (cherry picked from commit a34c9eb)
urso
pushed a commit
that referenced
this pull request
May 2, 2018
This uses the same approach and code as the Kibana dashboards loader. Fixes #6921.
urso
pushed a commit
that referenced
this pull request
May 2, 2018
tsg
added a commit
to tsg/beats
that referenced
this pull request
May 2, 2018
This uses the same approach and code as the Kibana dashboards loader. Fixes elastic#6921. (cherry picked from commit a7c9062)
andrewkroh
pushed a commit
that referenced
this pull request
May 2, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Ensure the dashboard zip is sane This adds a check that all files from the dashboard zip file are pointing to the right target, and don't override other configs. * changelog * addressed comment (cherry picked from commit 028a3fd)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#6996) This uses the same approach and code as the Kibana dashboards loader. Fixes elastic#6921. (cherry picked from commit b514dd1)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#6995) * Ensure the dashboard zip is sane (elastic#6921) * Ensure the dashboard zip is sane This adds a check that all files from the dashboard zip file are pointing to the right target, and don't override other configs. * changelog * addressed comment (cherry picked from commit 028a3fd) * cleanup changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check that all files from the dashboard zip file
are pointing to the right target, and don't override other configs.