Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 6.2: multiple doc changes (#6623, #6650, #6651, #6652, #6654, #6655, #6786, #6849, #6851) #6986

Merged
merged 9 commits into from
May 3, 2018

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented May 2, 2018

Cherrypicks the following PRs into the 6.2 branch:

#6623
#6650
#6651
#6652
#6654
#6655
#6786 - Please confirm this belongs in 6.2
#6849
#6851

dedemorton and others added 9 commits May 1, 2018 17:28
The previous version used `go get` as a trick to clone the repository
in the correct path. However:

* the extra magic can be confusing
* the `go get` results in an error (no buildable Go files). The docs
  were telling the reader to ignore the error, but it seems the wording
  of the error is different now.

I think it's better to use a simple `git clone`, which is what we
use also in the main Contributing guide.
Should clone into ${GOPATH}/src/github.com/elastic/beats as following instructions point to files in that path.
@ruflin ruflin merged commit 59dab21 into elastic:6.2 May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants