Negotiate Docker API version #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
force-pushed
the
negotiate-docker-api-version
branch
2 times, most recently
from
7ae153b
to
f352bcf
Compare
New Docker versions have deprecated our hardcoded client API version (1.22), this change uses an API version negotiation mechanism to ensure compatibility. We should still upgrade to a newer client in the future, let's keep an eye on moby/moby#33989 and do it once we have something we can vendor.
exekias
force-pushed
the
negotiate-docker-api-version
branch
from
f352bcf
to
c0902e2
Compare
|
Do we need a backport here? |
exekias
added
needs_backport
exekias
added
v6.3.0
and removed
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jun 14, 2018
New Docker versions have deprecated our hardcoded client API version (1.22), this change uses an API version negotiation mechanism to ensure compatibility. We should still upgrade to a newer client in the future, let's keep an eye on moby/moby#33989 and do it once we have something we can vendor. (cherry picked from commit 253bc71)
ruflin
pushed a commit
that referenced
this pull request
Jun 15, 2018
* Negotiate Docker API version (#7165) New Docker versions have deprecated our hardcoded client API version (1.22), this change uses an API version negotiation mechanism to ensure compatibility. We should still upgrade to a newer client in the future, let's keep an eye on moby/moby#33989 and do it once we have something we can vendor. (cherry picked from commit 253bc71) * Update CHANGELOG.asciidoc
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jul 10, 2018
Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542
ruflin
pushed a commit
that referenced
this pull request
Jul 11, 2018
Introducing API version negotiation (#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes #7542
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jul 11, 2018
Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit 2215d24)
ruflin
pushed a commit
that referenced
this pull request
Jul 12, 2018
…rsions (#7567) Introducing API version negotiation (#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes #7542 (cherry picked from commit 2215d24)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…c#7177) * Negotiate Docker API version (elastic#7165) New Docker versions have deprecated our hardcoded client API version (1.22), this change uses an API version negotiation mechanism to ensure compatibility. We should still upgrade to a newer client in the future, let's keep an eye on moby/moby#33989 and do it once we have something we can vendor. (cherry picked from commit 51d15f3) * Update CHANGELOG.asciidoc
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…cker versions (elastic#7567) Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit cecb9a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Docker versions have deprecated our hardcoded client API version
(1.22), this change uses an API version negotiation mechanism to ensure
compatibility.
We should still upgrade to a newer client in the future, let's keep an
eye on moby/moby#33989 and do it once we have
something we can vendor.
Fixes #6989