Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql parser handling of connection phase #8173

Merged
merged 5 commits into from
Sep 7, 2018
Merged

Fix mysql parser handling of connection phase #8173

merged 5 commits into from
Sep 7, 2018
+59 −31

Commits on Sep 7, 2018

  1. Fix mysql parser handling of connection phase (elastic#8139) 

    The mysql protocol parser assumes that transactions can only be started
by the client. This is true once the connection has been negotiated
("command phase"), but not during initial handshake ("connection phase").

This causes parsing problems when a connection is monitored from the
start, as sometimes the connection phase leaves the parser confused on
which side is client.

This patch modifies how client-side is detected, which can only be done
by looking at the destination port.
    @adriansr
    adriansr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    50067d7 View commit details
    Browse the repository at this point in the history

  2. Updated CHANGELOG

    @adriansr
    adriansr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    5cd9070 View commit details
    Browse the repository at this point in the history

  3. Remove unreachable branch

    @adriansr
    adriansr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    a38aeda View commit details
    Browse the repository at this point in the history

  4. Use tcp.Direction{Original|Reverse} constants

    @adriansr
    adriansr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ecf8264 View commit details
    Browse the repository at this point in the history

  5. Improve test

    @adriansr
    adriansr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    bce039a View commit details
    Browse the repository at this point in the history