Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container image for docker metricsets #8438

Merged
merged 6 commits into from
Sep 28, 2018
Merged

add container image for docker metricsets #8438

merged 6 commits into from
Sep 28, 2018

Conversation

pohzipohzi
Copy link

this fixes #8214

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@exekias
Copy link
Contributor

exekias commented Sep 26, 2018

thank you for taking this @pohzipohzi 🎉 🎉

It's looking good to me, could you please add a changelog entry?

jenkins, test this please

@pohzipohzi
Copy link
Author

hey @exekias . Sorry I forgot about that. Here you go

CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@exekias
Copy link
Contributor

exekias commented Sep 27, 2018

jenkins, test this please

@exekias
Copy link
Contributor

exekias commented Sep 27, 2018

Waiting for green 👍 thank you so much for taking this! 🎉 🎉 🌮

@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Sep 28, 2018
@exekias exekias merged commit e7f50bf into elastic:master Sep 28, 2018
@kierenj
Copy link

kierenj commented Sep 28, 2018

thanks @pohzipohzi (I originally requested this) :)

@exekias exekias added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 1, 2018
exekias pushed a commit to exekias/beats that referenced this pull request Oct 1, 2018
* add container image for docker metricsets

(cherry picked from commit e7f50bf)
exekias added a commit that referenced this pull request Oct 5, 2018
* add container image for docker metricsets

(cherry picked from commit e7f50bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker.container.image on docker/cpu stats (Metricbeat)
4 participants