Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Read entire body before closing connection #8660

Merged
merged 3 commits into from
Oct 23, 2018

Commits on Oct 19, 2018

  1. [Heartbeat] Read entire body before closing connection

    This fixes an issue where the connection would be closed after only a partial body read. The RoundTripper would close the conn before returning the response which included a partially buffered body. This would actually work for short responses, since the backing bufio would do a partial read, but would fail on all but the shortest responses.
    
    Normally connection lifecycle is handled outside the realm of the `RoundTripper`, but for our purposes we don't want to re-use connections. Since it is a requirement that all response bodies be closed, we can piggy-back on top of that to ensure the connection is closed.
    
    Fixes elastic#8588
    andrewvc committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    b5d1e79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b5d908 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Configuration menu
    Copy the full SHA
    8a2ff56 View commit details
    Browse the repository at this point in the history