Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #8839 to 6.5: Fix heartbeat docs for config reloading #8840

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

andrewvc
Copy link
Contributor

Cherry-pick of PR #8839 to 6.5 branch. Original message:

This commit fixes a nasty bug in the docs for config reloading where the reload.enabled option wasn't documented. Without this config reloading does not work.

This commit also adds these config options to the heartbeat.reference.yml file, which was an oversight in the original PR.

This commit fixes a nasty bug in the docs for config reloading where the `reload.enabled` option wasn't documented. Without this config reloading does not work.

This commit also adds these config options to the heartbeat.reference.yml file, which was an oversight in the original PR.

(cherry picked from commit 95df3e7)
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Contributor Author

Test failures unrelated

@andrewvc andrewvc merged commit 7861e60 into elastic:6.5 Oct 31, 2018
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
This commit fixes a nasty bug in the docs for config reloading where the `reload.enabled` option wasn't documented. Without this config reloading does not work.

This commit also adds these config options to the heartbeat.reference.yml file, which was an oversight in the original PR.

(cherry picked from commit 95df3e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants