Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging trace at debug level for the pipeline client. #9016

Merged
merged 6 commits into from
Dec 11, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 9, 2018

To allow easier debugging when events are not sent by the output we
have added a few log statements at debug level for the onFilteredOut and
the onDroppedOnPublish events.

@ph ph added in progress Pull request is currently in progress. libbeat needs_backport PR is waiting to be backported to other branches. labels Nov 9, 2018
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the changes. But a little more human readable texts would be nice.

To allow easier debugging when events are not sent by the output we
have added a few log statements at debug level for the onFilteredOut and
the onDroppedOnPublish events.
@ph ph force-pushed the fix/adding-more-logging-for-client-pipeline branch from f4490e3 to 6da11e9 Compare December 6, 2018 20:23
@ph ph added review and removed in progress Pull request is currently in progress. labels Dec 6, 2018
@ph
Copy link
Contributor Author

ph commented Dec 6, 2018

I've updated the log message, I wanted to keep the same style as the other log in the file.

@ph
Copy link
Contributor Author

ph commented Dec 6, 2018

Backport for 6.x 6.5

@ph ph merged commit 465b1a2 into elastic:master Dec 11, 2018
ph added a commit to ph/beats that referenced this pull request Feb 4, 2019
* Add logging trace at debug level for the pipeline client.

To allow easier debugging when events are not sent by the output we
have added a few log statements at debug level for the onFilteredOut and
the onDroppedOnPublish events.

(cherry picked from commit 465b1a2)
@ph ph added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 4, 2019
ph added a commit that referenced this pull request Feb 5, 2019
…peline client. (#10529)

* Add logging trace at debug level for the pipeline client. (#9016)

* Add logging trace at debug level for the pipeline client.

To allow easier debugging when events are not sent by the output we
have added a few log statements at debug level for the onFilteredOut and
the onDroppedOnPublish events.

(cherry picked from commit 465b1a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants