Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename source.hostname to source.domain #9027

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

andrewkroh
Copy link
Member

Rename the source.hostname field used by the auditd module to source.domain to follow the ECS 1.0-beta1 conventions.

Rename the `source.hostname` field used by the auditd module to `source.domain` to follow the ECS 1.0-beta1 conventions.
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Could you also add this to the ecs-migration.yml file?

@andrewkroh
Copy link
Member Author

The change to ecs-migration is already there.

I do need to update the changlog with the PR number (reminder to self).

@andrewkroh andrewkroh merged commit f0f3bc3 into elastic:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants