Version Information for kafka-output unclear #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct.
A minimum version smaller than 0.11 is valid, but not supported.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins, test this |
jsoriano
added
the
needs_backport
dedemorton
previously requested changes
Nov 13, 2018
The link text is not necessary
|
jenkins, test this |
jsoriano
dismissed
dedemorton’s stale review
I think changes were already addressed
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Nov 19, 2018
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct. (cherry picked from commit b007837)
jsoriano
added
v6.6.0
and removed
needs_backport
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Nov 19, 2018
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct. (cherry picked from commit b007837)
|
@gigallucci there seems to be some problem with your CLA, it appeared as signed before merging but not now, did you sign it? |
|
Hmm, that's very odd. Actually, I signed the CLA. Maybe it's because I changed my github name. I found it too long :) I will do it again. |
|
I tried to sign it again, but it did not work. When i confirm my email i get te message, that i have already verified the signature. |
|
Umm, not sure what happened, but after you retried the commit appears as verified here and in the backports, so everything fine 🙂 Thanks! |
jsoriano
added a commit
that referenced
this pull request
Nov 27, 2018
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct. (cherry picked from commit b007837)
jsoriano
added a commit
that referenced
this pull request
Nov 27, 2018
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct. (cherry picked from commit b007837)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#9144) In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.00 are supported. In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 2.0.0 are valid. It would be useful to mention the supported versions. This would avoid misinterpretations. I assume that the information in the paragraph "compatibility" is correct. (cherry picked from commit 0fd7203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the paragraph "compatibility" it is mentioned that versions 0.11 to 2.0.0 are supported.
In the description of the parameter "version" it is mentioned that all versions from 0.8.2.0 to 1.1.1 are valid.
It would be useful to mention the supported versions. This would avoid misinterpretations.
I assume that the information in the paragraph "compatibility" is correct.