Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on docker healthcheck collection #9171

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

jsoriano
Copy link
Member

Fix panic on docker healthcheck collection on dockers without healthchecks.

@jsoriano jsoriano added bug module review Metricbeat Metricbeat containers Related to containers use case labels Nov 20, 2018
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a backport?

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Nov 20, 2018
@jsoriano
Copy link
Member Author

Yes, I will backport this.

@jsoriano
Copy link
Member Author

jenkins, test this again

@ruflin
Copy link
Member

ruflin commented Nov 20, 2018

Don't forget the open a PR for the failing test ;-)

@jsoriano
Copy link
Member Author

Don't forget the open a PR for the failing test ;-)

First one was a connectivity issue, second one was a SIGQUIT 🤔

@jsoriano jsoriano merged commit 1c43d6c into elastic:master Nov 20, 2018
@jsoriano jsoriano deleted the docker-empty-healthcheck branch November 20, 2018 19:44
@jsoriano jsoriano added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 20, 2018
jsoriano added a commit to jsoriano/beats that referenced this pull request Nov 20, 2018
Fix panic on docker healthcheck collection on dockers without healthchecks.

(cherry picked from commit 1c43d6c)
jsoriano added a commit to jsoriano/beats that referenced this pull request Nov 20, 2018
Fix panic on docker healthcheck collection on dockers without healthchecks.

(cherry picked from commit 1c43d6c)
jsoriano added a commit that referenced this pull request Nov 21, 2018
Fix panic on docker healthcheck collection on dockers without healthchecks.

(cherry picked from commit 1c43d6c)
jsoriano added a commit that referenced this pull request Nov 23, 2018
Fix panic on docker healthcheck collection on dockers without healthchecks.

(cherry picked from commit 1c43d6c)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Fix panic on docker healthcheck collection on dockers without healthchecks.

(cherry picked from commit 558eda7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants