Assume all swap memory is free on values overflow #9383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens.
jsoriano
added
module
review
libbeat
Metricbeat
|
Pinging @elastic/infrastructure |
jsoriano
added
the
needs_backport
ruflin
reviewed
Dec 6, 2018
sayden
reviewed
Dec 6, 2018
CHANGELOG.asciidoc
Outdated
| @@ -38,6 +38,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
| - Fix autodiscover configurations stopping when metadata is missing. {pull}8851[8851] | |||
| - Log events at the debug level when dropped by encoding problems. {pull}9251[9251] | |||
| - Refresh host metadata in add_host_metadata. {pull}9359[9359] | |||
| - Handle cases of free swap being bigger than total swap by assuming no swap is being used. {issue}6271[6271] {pull}[] | |||
There was a problem hiding this comment.
You haven't written the pull number. Maybe I'd add the module involved too
|
Thanks for the reviews, changes addressed. |
ruflin
reviewed
Dec 6, 2018
ruflin
approved these changes
Dec 6, 2018
Co-Authored-By: jsoriano <jaime.soriano@elastic.co>
jsoriano
force-pushed
the
swap-overflow
branch
from
c5b0e4c
to
c13c44c
Compare
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 6, 2018
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens. (cherry picked from commit 7d9b2e3)
jsoriano
added
v6.6.0
and removed
needs_backport
jsoriano
added a commit
that referenced
this pull request
Dec 10, 2018
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens. (cherry picked from commit 7d9b2e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been reports about user swap memory being a value that looks
like an overflow. At the moment used swap memory is calculated as the
value of total memory minus the free memory, so this means that free
memory is bigger than total in some cases. This isn't possible in
principle. Assume that no swap is being used if that happens.
Closes #6271