Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved objects in filebeat haproxy dashboard #9417

Merged
merged 6 commits into from
Dec 10, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 6, 2018

Fix issues with saved objects in filebeat dashboard:

  • Use proper field for client ip
  • Add the panels to the dashboard
  • Use same map configuration as in other modules for geoip view

Fixes #9389

@jsoriano jsoriano added module review Filebeat Filebeat :Dashboards needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Dec 6, 2018
@jsoriano jsoriano self-assigned this Dec 6, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/infrastructure

@jsoriano jsoriano force-pushed the filebeat-haproxy-fix-dashboard branch from 8d6abb7 to 0bea8b6 Compare December 6, 2018 11:38
@@ -156,7 +155,7 @@
"enabled": true,
"id": "1",
"params": {
"field": "haproxy.client_ip"
"field": "haproxy.client.ip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change the name of this field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in #8637, before the module was released, but without checking the dashboard :(

@ruflin ruflin requested a review from sayden December 6, 2018 14:03
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit cb898ff into elastic:master Dec 10, 2018
@jsoriano jsoriano deleted the filebeat-haproxy-fix-dashboard branch December 10, 2018 15:11
jsoriano added a commit to jsoriano/beats that referenced this pull request Dec 10, 2018
Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit cb898ff)
@jsoriano jsoriano added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 10, 2018
jsoriano added a commit to jsoriano/beats that referenced this pull request Dec 10, 2018
Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit cb898ff)
jsoriano added a commit that referenced this pull request Dec 11, 2018
Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit cb898ff)
jsoriano added a commit that referenced this pull request Dec 12, 2018
Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit cb898ff)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ic#9465)

Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit 8151470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants