Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update object enabled:false index pattern attribs #9644

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Dec 18, 2018

to eventually be used by elastic/apm-server#1666

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would probably best to have @ruflin take a look too if it can wait a few hours.

@graphaelli
Copy link
Member Author

I am planning to backport to 6.x but think it qualifies as a bug fix, so will wait for @ruflin.

@ruflin ruflin added review needs_backport PR is waiting to be backported to other branches. labels Dec 19, 2018
@urso
Copy link

urso commented Dec 19, 2018

If it's a bug fix or breaking change, please add a changelog entry as well.

@simitt
Copy link
Contributor

simitt commented Dec 19, 2018

jenkins, retest this please

@simitt simitt merged commit a615441 into elastic:master Dec 19, 2018
simitt pushed a commit to simitt/beats that referenced this pull request Dec 19, 2018
* update object enabled:false index pattern attribs
simitt pushed a commit to simitt/beats that referenced this pull request Dec 19, 2018
* update object enabled:false index pattern attribs
@simitt simitt removed the needs_backport PR is waiting to be backported to other branches. label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants