Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IPv6 zone id in IIS filebeat ingest pipeline #9869

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jan 3, 2019

Possible workaround for #9836, this may be needed in other modules if other services also log IPv6 addresses with zone id.

Wait for elastic/elasticsearch#37107 before deciding what to do about this.

@jsoriano jsoriano added module discuss Issue needs further discussion. Filebeat Filebeat blocked labels Jan 3, 2019
@jsoriano jsoriano requested a review from a team as a code owner January 3, 2019 15:51
@jsoriano jsoriano self-assigned this Jan 3, 2019
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.
@jsoriano jsoriano changed the title Handle IPv6 zone id in ISS filebeat ingest pipeline Handle IPv6 zone id in IIS filebeat ingest pipeline Jan 4, 2019
@ruflin ruflin added the Team:Integrations Label for the Integrations team label Jan 7, 2019
@jsoriano
Copy link
Member Author

jsoriano commented Jan 7, 2019

I am going to merge this and backport it to 6.x, as a workaround for elastic/elasticsearch#37107, if it happens in more modules we can apply the same workaround or wait for a more general solution.

@jsoriano jsoriano merged commit d59ae8c into elastic:master Jan 7, 2019
@jsoriano jsoriano deleted the filebeat-ipv6-zone-id branch January 7, 2019 19:00
jsoriano added a commit to jsoriano/beats that referenced this pull request Jan 7, 2019
IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
@jsoriano jsoriano added the v6.7.0 label Jan 7, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Jan 7, 2019
IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
@jsoriano jsoriano added the v6.6.0 label Jan 7, 2019
jsoriano added a commit that referenced this pull request Jan 9, 2019
…pipeline (#9932)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
jsoriano added a commit that referenced this pull request Jan 9, 2019
…pipeline (#9933)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
webmat added a commit that referenced this pull request Jan 11, 2019
…ccess logs (#9955)

- Introduce IPv6 zone workaround iis.access log as well, resolving #9836.
- Update the IPv6 zone fix (#9869) for iis.error to use the ECS `.address` field instead of a transient field.
- Convert many fields under `iis.error.*` to ECS. Previous field names are field aliases towards the new corresponding ECS field:
  - iis.error.remote_ip => source.address
  - iis.error.remote_port => source.port
  - iis.error.server_ip => destination.address
  - iis.error.server_port => destination.port
  - iis.error.http_version => http.version
  - iis.error.method => http.request.method
  - iis.error.url => url.original
  - iis.error.response_code => http.response.status_code
  - iis.error.geoip.* => source.geo.*
  - read_timestamp => event.created (not aliased, still used elsewhere)
- Update field aliases introduced in #9084 to point to `.address` instead of `.ip`, since this value can be ambiguous. The IP field is populated with the cleaned up IP without the zone. This is also true for the `.ip` fields under populated by the error logs.
  - iis.access.remote_ip => source.address
  - iis.access.server_ip => destination.address
- Coerce to long: source.port, destination.port and http.response.status_code in the iis.error fileset
jsoriano added a commit to jsoriano/beats that referenced this pull request Jan 14, 2019
…ingest pipeline (elastic#9933)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
(cherry picked from commit 5f1f6ca)
jsoriano added a commit that referenced this pull request Jan 21, 2019
…beat ingest pipeline (#10057)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
(cherry picked from commit 5f1f6ca)
(cherry picked from commit e05f967)

Co-authored-by: Mathieu Martin <webmat@gmail.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ingest pipeline (elastic#9933)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit dad84e9)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…id in IIS filebeat ingest pipeline (elastic#10057)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit dad84e9)
(cherry picked from commit 5f1f6ca)
(cherry picked from commit e05f967)

Co-authored-by: Mathieu Martin <webmat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked discuss Issue needs further discussion. Filebeat Filebeat module Team:Integrations Label for the Integrations team v6.6.0 v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants