Support haproxy log lines without captured headers #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers.
jsoriano
added
bug
module
review
Filebeat
13 tasks
ruflin
approved these changes
Jan 9, 2019
jsoriano
force-pushed
the
filebeat-haproxy-headers
branch
from
0c61e55
to
3928ecd
Compare
jsoriano
force-pushed
the
filebeat-haproxy-headers
branch
from
3928ecd
to
c088834
Compare
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 9, 2019
Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers. (cherry picked from commit b39d780)
jsoriano
added
v6.7.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 9, 2019
Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers. (cherry picked from commit b39d780)
jsoriano
added a commit
that referenced
this pull request
Jan 10, 2019
Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers. (cherry picked from commit b39d780)
jsoriano
added a commit
that referenced
this pull request
Jan 10, 2019
Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers. (cherry picked from commit b39d780)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#9969) Haproxy can capture headers from http requests and responses and log them. This is not done by default but current filebeat module expects it. Make captured headers optional, and collect them only if both request and response headers are configured. If only one is configured, the log is parsed but headers not collected as we cannot know if they are request or response headers. (cherry picked from commit 8e21bd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haproxy can capture headers from http requests and responses and log
them. This is not done by default but current filebeat module expects
it.
Make captured headers optional, and collect them only if both request
and response headers are configured. If only one is configured, the log
is parsed but headers not collected as we cannot know if they are
request or response headers.
Fix #9463