Add http.request.body.
#263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we allow for deep inspection of response body already, I don't see why we wouldn't have a field for the request body as well. I think this was simply overlooked?
ruflin
requested changes
Dec 10, 2018
| @@ -851,12 +851,12 @@ | |||
| Referrer for this HTTP request. | |||
| example: https://blog.example.com/ | |||
|
|
|||
| - name: response.status_code | |||
| - name: request.body | |||
There was a problem hiding this comment.
This seems to conflict with #239
There was a problem hiding this comment.
Well 239 is about adding the size metrics.
This current PR is adding the other body with the same semantics as it had before. But if we go forward with 239's proposal to nest the body content at body.content, then this implementation will indeed need to change.
Was just trying to keep concerns separate ;-)
|
Will be implemented directly in #239, to introduce a consistent desired state all at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we allow for deep inspection of response body already, I don't see why we wouldn't have a field for the request body as well. I think this was simply overlooked?
This would address an issue we have with migrating the Filebeat elasticsearch log module: elastic/beats#9293