Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS keychain support to use non-deprecated API #2961

Open
faec opened this issue Jun 29, 2023 · 3 comments
Open

Update MacOS keychain support to use non-deprecated API #2961

faec opened this issue Jun 29, 2023 · 3 comments
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team

Comments

@faec
Copy link
Contributor

faec commented Jun 29, 2023

As mentioned in #2639, most build and test actions on Mac produce a lot of noisy warning text related to the deprecation (in MacOS 10.10) of the old SecKeychain functions in Security.framework. We can suppress the build warnings for short-term convenience, but the oldest MacOS we support is 10.13, so we no longer need to support this deprecated API -- we should migrate our keychain handling to the current supported alternative.

@faec faec added bug Something isn't working Team:Elastic-Agent Label for the Agent team labels Jun 29, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@jlind23
Copy link
Contributor

jlind23 commented Mar 11, 2024

@pchila is this something you touched touch while working on #3866?

@pchila
Copy link
Member

pchila commented Mar 11, 2024

@jlind23 I didn't touch the internal implementation of the Mac OS keychain vault, I only separated the 2 implementations of vaults we have so that we can use both on darwin (see #4362).

If we need to change the implementation to move away from deprecated APIs there should be no conflicts (also, it still needs to be done 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

4 participants