Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beats diagnostic tooling - Phase II #94

Closed
1 of 6 tasks
Tracked by #21965
jlind23 opened this issue Jan 10, 2022 · 3 comments
Closed
1 of 6 tasks
Tracked by #21965

Beats diagnostic tooling - Phase II #94

jlind23 opened this issue Jan 10, 2022 · 3 comments
Labels
debugging Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@jlind23
Copy link
Contributor

jlind23 commented Jan 10, 2022

Following the work done here - elastic/beats#21965

We should now work on collecting metrics and some other tasks:

  • Libbeat collects metrics every 10s into ring buffer (N=60)
  • Expose internal metrics via API
  • elastic-agent diagnostics: filebeat and metricbeat configuration beats#29898
  • Diagnostics tool reads metrics ring buffer
  • (optional) CLI subcommand diag add to add extra files and directories to a diagnostics report.
    log / capture std from the processes started
  • Remove credentials being dumped as part of the diagnotic command
@jlind23 jlind23 added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team debugging labels Jan 10, 2022
@botelastic
Copy link

botelastic bot commented Jan 10, 2022

This issue doesn't have a Team:<team> label.

@jlind23 jlind23 changed the title Collect metrics: Beats diagnostic tooling - Phase II Jan 10, 2022
@ph
Copy link
Contributor

ph commented Jan 17, 2022

Concerning the credentials, we could add filtering on the exported configuration and replace obvious authorization field, like password, passphrase, token, ssl.key, this would reduce the area of information we could leak. this won't be perfect.

Ideally, the types in the configuration should allow us to do that, but we types aren't known at that time.

@jlind23 jlind23 transferred this issue from elastic/beats Mar 7, 2022
@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
@jlind23
Copy link
Contributor Author

jlind23 commented Apr 4, 2023

Closing as it is part of other issues :
https://github.com/elastic/ingest-dev/issues/1791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugging Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

2 participants