[Metric] It's not possible to format non-numeric value

[mbondyra]

Describe the issue

1. Go here: https://codesandbox.io/s/long-legend-sizing-forked-h83q6s?file=/src/App.tsx:127-134 and analyze the code, specifically the passed valueFormatter.
2. It will never run if the value is not a number
3. If you change it to number, the valueFormatter runs

Specifically, here's my usecase: I am working on adding other types of data to be supported by visualization ('string', 'boolean', 'number', 'ip', 'date') to match the legacy metric.

While strings, booleans and ip don't need extra format to be passed, we need it for dates as we get them as strings. Not sure if there's another way to handle that. Let me know if that's not a bug and there is another way!

[mbondyra]

Just an update from my side: I found a way of passing already a formatted value. That's probably not ideal, but works! So instead of

{
    value,
    valueFormatter: formatPrimaryMetric,
}

I pass

{
    value: formatPrimaryMetric(value),
}

[nickofthyme]

Good point @mbondyra I think in #1817 we just assumed it would be redundant to format a string but I think there is definitely a use for this. In any case I think it's strange the valueFormatter has no affect with string values.