Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric] Medium and long text in metric is cut #2213

Closed
mbondyra opened this issue Oct 23, 2023 · 5 comments · Fixed by #2437
Closed

[metric] Medium and long text in metric is cut #2213

mbondyra opened this issue Oct 23, 2023 · 5 comments · Fixed by #2437
Labels
bug Something isn't working :metric Related to Metric chart needs design A design pass is required and not available

Comments

@mbondyra
Copy link
Contributor

Lens issue: elastic/kibana#169505 (comment)

Screenshot 2023-10-23 at 09 47 48 Screenshot 2023-10-23 at 09 47 08

While the secondary metric can go multiline, the primary metric has a no-wrap policy for the CSS white-space property.

I've tried to quickly check what would happen without that nowrap thing but it introduces other issues:

Screenshot 2023-10-23 at 09 48 20 Screenshot 2023-10-23 at 09 48 05

Originally posted by @dej611 in elastic/kibana#169258 (comment)

@mbondyra mbondyra added the bug Something isn't working label Oct 23, 2023
@nickofthyme
Copy link
Collaborator

nickofthyme commented Oct 23, 2023

Given the nature of the secondary metric it was easier to expect that it could go on multiple lines, it is also way smaller and then way more easy to deal with. At the same time this is an interesting conversation to have because introducing text might make worth to talk about multi-lines for values/strings as well. Thank you for pointing this out!

Originally posted by @gvnmagni in elastic/kibana#169258 (comment)

@markov00 markov00 added :metric Related to Metric chart needs design A design pass is required and not available labels Dec 6, 2023
@gvnmagni
Copy link

gvnmagni commented Apr 22, 2024

Related to #2306

@markov00
Copy link
Member

@gvnmagni do you think we can close this considering the work done on #2306? It doesn't fully solve this problem in some cases but there is no much that we can do I believe

@gvnmagni
Copy link

I feel the same, given the complexity of the wrapping logics I feel that fit and custom modes introduced with the update solve the problem, at least for now.

@markov00
Copy link
Member

Great, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :metric Related to Metric chart needs design A design pass is required and not available
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants