Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilayer time axis should read dow from moment locale #2361

Closed
3 tasks done
nickofthyme opened this issue Mar 14, 2024 · 0 comments · Fixed by #2362
Closed
3 tasks done

Multilayer time axis should read dow from moment locale #2361

nickofthyme opened this issue Mar 14, 2024 · 0 comments · Fixed by #2362
Assignees
Labels
:axis Axis related issue enhancement New feature or request :timeslip Timeslip related issues :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Mar 14, 2024

Is your feature request related to a problem? Please describe.

In the multilayer time axis we hard code the start day of the week to 1 (aka Monday). This does not allow the chart consumer to change this to adapt to the data.

Demo

Zight Recording 2024-03-14 at 03 27 43 PM

See demo here.

Describe the solution you'd like
The start day of the week should be driven by the moment.localeData().firstDayOfWeek()

Describe alternatives you've considered
N/A

Additional context
This only applies to the tick placement and labels, not the placement of the rendered geometries.

Kibana Cross Issues

elastic/kibana#178115

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request :timeslip Timeslip related issues :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant