Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nice option for axis ticks #397

Closed
nickofthyme opened this issue Sep 27, 2019 · 3 comments · Fixed by #1087
Closed

Add nice option for axis ticks #397

nickofthyme opened this issue Sep 27, 2019 · 3 comments · Fixed by #1087
Assignees
Labels
:axis Axis related issue enhancement New feature or request released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 27, 2019

Is your feature request related to a problem? Please describe.
Allow user to set the option for nice tick ending values.

Describe alternatives you've considered
User manually sets the domain based on dataset

Additional context
An attempt was made in #384 but ran into issues with ticks aligning to the geometry domain.

See this branch for attempt master...nickofthyme:feat/nice-ticks

computeSeriesDomains computes the xDomain and yDomains which are then passed to all subsequent function. I think this would be the best place to set the nice value so the domain is set from the beginning.

Better yet is this could return the xScale and yScales that would be better so the scale is not instantiated in the getAxisTicksPositions and then in getScaleForAxisSpec

@markov00
Copy link
Member

An attempt was made in #384 but ran into issues with ticks aligning to the geometry domain.

@nickofthyme do you remember a specific SB story that shows that tick alignment problem?

@nickofthyme
Copy link
Collaborator Author

No this was so long ago I can't remember what problems there were with tick alignments.

@nickofthyme
Copy link
Collaborator Author

🎉 This issue has been resolved in version 28.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants