Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Goal] Replace Kibana TSVB Goal with es-charts #961

Closed
6 of 8 tasks
stratoula opened this issue Jan 5, 2021 · 3 comments
Closed
6 of 8 tasks

[Goal] Replace Kibana TSVB Goal with es-charts #961

stratoula opened this issue Jan 5, 2021 · 3 comments
Labels
enhancement New feature or request :goal/gauge (old) Old Goal/Gauge chart related issues kibana cross issue Has a Kibana issue counterpart meta ...meta issue

Comments

@stratoula
Copy link

stratoula commented Jan 5, 2021

Is your feature request related to a problem? Please describe.
I am working on replacing the TSVB goal chart with the es-charts goal and I can see some features that are not supported so I am creating this issue in order to discuss them.

So far I have managed to replace it and it seems really good. I have set the target and actual to 0 in order to look more with the current TSVB implementation but I am not sure if this is correct. I think we should discuss this.

Current implementation example:

Elastic charts implementation example (target 0):

Elastic charts implementation example (target set to value):

The first thing that I notice is that when I choose to display my chart s half-circle there is an empty space below that if it didn't exist my chart would appear bigger. I assume that this happens because I have the labelMajor and labelMinor to empty string. Can I choose that I don't want to be rendered in order to gain this space?

As you can see on the screenshot below the user can change the Inner Line width (it is the border line), the Gauge line width (the width of the goal line) and the text color. I think that changing the Inner line width is not so important but the other two maybe they are. Wdyt?

When I have multiple goal charts configured to be displayed as circle, I need to place an additional label to display the split term. It is not displayed very well, and the same thing occurs when I have a title that is quite big (see screenshots below). I think that the texts should be somehow responsive, any ideas here?

Kibana Cross Issues
Kibana related issue here

Checklist

Delete any items that are not applicable to this feature request.

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@stratoula stratoula added enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :goal/gauge (old) Old Goal/Gauge chart related issues labels Jan 5, 2021
@markov00 markov00 added the meta ...meta issue label Jul 9, 2021
@nickofthyme
Copy link
Collaborator

Do we want to replace the TSVB Goal chart with the new Bullet chart?

@stratoula
Copy link
Author

No with the bullet chart. When I created the issue it was mostly for replacing it with the EC goal (same look and feel with the TSVB one).

When we added the TSVB to Lens conversion the transition goes to Lens new metric which also makes sense. I think that possibly we should not do anything but rather prioritize the deprecation of TSVB but happy to hear your thoughts!

@nickofthyme
Copy link
Collaborator

That's good with me, I think the new bullet is too much of a divergence from the current TSVB chart anyways. As mentioned in the sync, I think having the ability to convert existing TSVB goal/gauge to Lens Metric then to Lens Bullet is a nice transition.

Closing unless otherwise objected.

@nickofthyme nickofthyme closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :goal/gauge (old) Old Goal/Gauge chart related issues kibana cross issue Has a Kibana issue counterpart meta ...meta issue
Projects
None yet
Development

No branches or pull requests

3 participants