Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch/elasticsearch 6.8.0 removes IndicesNamespace::deleteMapping #1235

Closed
cweiske opened this issue Jul 6, 2022 · 2 comments
Closed

Comments

@cweiske
Copy link

cweiske commented Jul 6, 2022

Summary of problem or feature request

Version 6.8.0 removes the method Elasticsearch\Namespaces\IndicesNamespace::deleteMapping() with commit 2da5f93.

This method existed in 6.7.2.

Per semantic versioning, feature releases like the update from 6.7 to 6.8 may not break existing APIs, and here the API has been broken.
This leads to problems in the drupal module elasticsearch_connector: https://www.drupal.org/project/elasticsearch_connector/issues/2824539

@ezimuel
Copy link
Contributor

ezimuel commented Jul 8, 2022

@cweiske this is a very old feature that has been removed in Elasticsearch 2.0. Unfortunately, since v.6.8.0 we didn't have a code generator in place and this Elasticsearch\Namespaces\IndicesNamespace::deleteMapping() remained unsed since than. This means even if elasticsearch-php exposes it this do not have any effect on Elasticsearch 😞 . With 6.8.0 we released a code generator for mapping the Elasticsearch API specification. That's why this function has been removed automatically since it was not anymore part of the latest API.
We should have included this in the BREAKING_CHANGES.md file. I'm sorry for the inconvenient 😢

@cweiske
Copy link
Author

cweiske commented Jul 14, 2022

Putting it into BREAKING_CHANGES.md would not have helped, because you still would have broken the semantic versioning contract.
Having an empty deleteMapping() method would be the correct way to fix this in 6.x, while in 7.x and later it could safely be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants