Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC in extractArgument() function #1414

Open
diwms opened this issue Sep 24, 2024 · 0 comments
Open

BC in extractArgument() function #1414

diwms opened this issue Sep 24, 2024 · 0 comments

Comments

@diwms
Copy link

diwms commented Sep 24, 2024

Hi there 👋

I've upgraded elasticsearch/elasticsearch library from version 6.1.0 to 6.8.0 and observed interesting situation after some investigations I come to conclusion that this change is BC break. See the screenshot:

Image

Basically, because of extra casting $value variable to an array, in case if body is an object - keys are corrupted.

I'm working on a fix in the own codebase, but meanwhile, maybe there is something behind this change? Maybe some configurations or etc.
If this will be confirmed as a bug I can also work on a PR with proper reproducing test case and fix.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant