use request converter to generate python examples #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
miguelgrinberg
force-pushed
the
generate-examples-with-converter
branch
6 times, most recently
from
76a498b
to
f993de2
Compare
miguelgrinberg
force-pushed
the
generate-examples-with-converter
branch
from
f993de2
to
9e67739
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* use request converter to generate examples * updated examples * use correct license (cherry picked from commit 4ee4650)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
generate-examples.pyscript with a new version written in JavaScript (heavily based on the JS client's example generator) that uses the request converter library.