From b70f4185585e88d8571394792df3156063072299 Mon Sep 17 00:00:00 2001 From: Jonathan Buttner Date: Wed, 11 Oct 2023 17:23:30 -0400 Subject: [PATCH] Adding some logging for evictor thread --- .../xpack/inference/external/http/HttpClientManager.java | 5 +++++ .../xpack/inference/external/http/IdleConnectionEvictor.java | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/HttpClientManager.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/HttpClientManager.java index e4b73ad19f43a..862170a229b41 100644 --- a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/HttpClientManager.java +++ b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/HttpClientManager.java @@ -24,6 +24,8 @@ import java.io.IOException; import java.util.List; +import static org.elasticsearch.core.Strings.format; + public class HttpClientManager implements Closeable { private static final Logger logger = LogManager.getLogger(HttpClientManager.class); /** @@ -143,6 +145,8 @@ boolean isEvictionThreadRunning() { // default for testing void setEvictionInterval(TimeValue evictionInterval) { + logger.debug(() -> format("Eviction thread's interval time updated to [%s]", evictionInterval)); + evictorSettings = new EvictorSettings(evictionInterval, evictorSettings.evictionMaxIdle); connectionEvictor.close(); @@ -151,6 +155,7 @@ void setEvictionInterval(TimeValue evictionInterval) { } void setEvictionMaxIdle(TimeValue evictionMaxIdle) { + logger.debug(() -> format("Eviction thread's max idle time updated to [%s]", evictionMaxIdle)); evictorSettings = new EvictorSettings(evictorSettings.evictionInterval, evictionMaxIdle); connectionEvictor.setMaxIdleTime(evictionMaxIdle); } diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/IdleConnectionEvictor.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/IdleConnectionEvictor.java index 7d9bf57f9d3bd..295c9b7b17946 100644 --- a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/IdleConnectionEvictor.java +++ b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/IdleConnectionEvictor.java @@ -19,6 +19,7 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicReference; +import static org.elasticsearch.core.Strings.format; import static org.elasticsearch.xpack.inference.InferencePlugin.UTILITY_THREAD_POOL_NAME; /** @@ -63,6 +64,8 @@ public synchronized void start() { } private void startInternal() { + logger.debug(() -> format("Idle connection evictor started with wait time: [%s] max idle: [%s]", sleepTime, maxIdleTime)); + Scheduler.Cancellable task = threadPool.scheduleWithFixedDelay(() -> { try { connectionManager.closeExpiredConnections(); @@ -80,6 +83,7 @@ private void startInternal() { @Override public void close() { if (cancellableTask.get() != null) { + logger.debug("Idle connection evictor closing"); cancellableTask.get().cancel(); } }