Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IndicesStatsRequest to expose CommonStatsFlags directly #10096

Closed
bleskes opened this issue Mar 15, 2015 · 0 comments
Closed

Move IndicesStatsRequest to expose CommonStatsFlags directly #10096

bleskes opened this issue Mar 15, 2015 · 0 comments
Assignees
@jtibshirani
Labels
>enhancement good first issue low hanging fruit help wanted adoptme

Comments

@bleskes
Copy link
Contributor

bleskes commented Mar 15, 2015

Currently IndicesStatsRequest has a method per possible index metric. Internally theses are stored using a CommonStatsFlags object. This means that every time we add a stat we need to remember to add a method and remember to map it in RestIndicesStatsAction rather we should just expose the underlying flag, just like NodesStatsRequest.indices() allowing for some automation in the mapping.
@clintongormley clintongormley changed the title Api: move IndicesStatsRequest to expose CommonStatsFlags directly Move IndicesStatsRequest to expose CommonStatsFlags directly Jun 8, 2015
@jtibshirani jtibshirani self-assigned this Apr 17, 2018
@jtibshirani jtibshirani mentioned this issue Apr 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtibshirani jtibshirani

Labels
>enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@clintongormley @colings86 @martijnvg @spinscale @bleskes @jtibshirani