Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only one way of specifying routing, version and version_type #13377

Closed
alexksikes opened this issue Sep 7, 2015 · 4 comments
Closed

Use only one way of specifying routing, version and version_type #13377

alexksikes opened this issue Sep 7, 2015 · 4 comments
Labels
:Core/Infra/REST API REST infrastructure and utilities >deprecation good first issue low hanging fruit help wanted adoptme v6.0.3

Comments

@alexksikes
Copy link
Contributor

Today we have a couple of ways of specifying the routing, version, and version
type of a given document request.

Beyond camelCase, we use:

_routing or routing
_version or version
_version_type or version_type

This makes the use of ParseField difficult for these parameters, as the camelCase of say _routing isn't routing. We should probably settle on using only one, or make ParseField handle this case.

Relates to #8988

@alexksikes alexksikes added discuss :Core/Infra/REST API REST infrastructure and utilities v2.1.0 labels Sep 7, 2015
@jpountz jpountz changed the title Use only of way of specifying routing, version and version_type Use only one way of specifying routing, version and version_type Sep 8, 2015
@jpountz
Copy link
Contributor

jpountz commented Sep 8, 2015

or make ParseField handle this case

Please no. :-)

+1 on settling on just one

@clintongormley
Copy link

Let's settle on a single form (I don't really care if it is _foo or foo) and deprecate the other form (with depr logging), but only remote it in 6.0.

@mariha
Copy link

mariha commented Jun 4, 2019

I was thinking of working on this issues, isn't it already fixed though? #27040 (comment)

@jpountz
Copy link
Contributor

jpountz commented Jun 5, 2019

Good catch @mariha it has been addressed indeed.

@jpountz jpountz closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >deprecation good first issue low hanging fruit help wanted adoptme v6.0.3
Projects
None yet
Development

No branches or pull requests

7 participants