Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom thread pools #17915

Closed
jasontedor opened this issue Apr 21, 2016 · 6 comments
Closed

Remove custom thread pools #17915

jasontedor opened this issue Apr 21, 2016 · 6 comments
Labels
>breaking :Core/Infra/Core Core issues without another label

Comments

@jasontedor
Copy link
Member

Today, we allow the creation of arbitrary custom thread pools. I'm not convinced this is a useful feature and do think that it is a dangerous one. I propose that we remove the capability for custom thread pools.

@jpountz
Copy link
Contributor

jpountz commented Apr 22, 2016

This would mean that plugins could not have dedicated thread pools anymore. They could use the generic threadpool instead, but this has the drawback that it is unbounded. Another option that was mentioned was to create a bounded thread pool that all plugins could share when they need a bounded thread pool. There were diverging opinions and we would like to hear @s1monw 's opinion before moving forward.

@jasontedor
Copy link
Member Author

They could use the generic threadpool instead, but this has the drawback that it is unbounded.

The generic thread pool will be bounded after #17017.

@s1monw
Copy link
Contributor

s1monw commented May 20, 2016

I think we should remove that option but need to be careful with the consequences. If plugins have long running tasks they might need a different infrastructure? Something like an internal long task pool we can only use from internal?

@s1monw
Copy link
Contributor

s1monw commented May 20, 2016

@uboness what do you think ^^ I think it can be bound and rejects quickly such that we don't have too many long running tasks going on at the same time?

@s1monw
Copy link
Contributor

s1monw commented May 27, 2016

removed the discuss label @uboness can you please comment

@jasontedor
Copy link
Member Author

Closed in favor of #18613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Core Core issues without another label
Projects
None yet
Development

No branches or pull requests

4 participants